Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate path to common test resources in IntelliJ #349

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

krzema12
Copy link
Owner

@krzema12 krzema12 commented Jan 9, 2025

Thanks to this, one can click in the IDE to go to the test resource:

Screenshot 2025-01-09 at 22 25 04

and invalid paths are highlighted with red:

Screenshot 2025-01-09 at 22 25 30

To achieve it, we need to have a leading slash, hence the changes in all call sites of stringFromResources function.

@krzema12
Copy link
Owner Author

krzema12 commented Jan 9, 2025

Failing on MacosX64 likely because of JetBrains/java-annotations#116

krzema12 added a commit that referenced this pull request Jan 10, 2025
Thanks to this, we'll be able to use `@Language("file-reference")` to
validate the paths in the IDE. Now it's impossible due to a bug in the
library that provides the annotation, see
JetBrains/java-annotations#116.

This PR is a mergeable part of
#349.
@krzema12 krzema12 marked this pull request as ready for review January 22, 2025 21:59
@krzema12 krzema12 enabled auto-merge (squash) January 22, 2025 22:00
@krzema12 krzema12 requested a review from OptimumCode January 22, 2025 22:00
@krzema12 krzema12 merged commit 2c11161 into main Jan 22, 2025
12 checks passed
@krzema12 krzema12 deleted the validate-path-to-common-resources-in-IntelliJ branch January 22, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants