Add local monitoring e2e test job in PR check workflow #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrams
reviewed
Jan 16, 2025
| @@ -125,3 +125,53 @@ jobs: | |||
| path: ./crc_manifest_results.tar | |||
| retention-days: 2 | |||
|
|
|||
| # This job runs an end-to-end test to validate the local monitoring workflow | |||
| test_crc_manifest_build_local_monitoring: | |||
There was a problem hiding this comment.
This will run only using the manifest image. Update another job to test with the PR build.
There was a problem hiding this comment.
Added a new job build_crc_local_monitoring to test local monitoring flow with the PR build.
chandrams
reviewed
Jan 16, 2025
.github/workflows/test-on-pr.yaml
Outdated
| if: always() | ||
| run: | | ||
| cd ${GITHUB_WORKSPACE} | ||
| tar cvf crc_manifest_results.tar kruize_local_monitoring_test_results |
There was a problem hiding this comment.
Update the archive file to match what is being uploaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
test_crc_manifest_build_local_monitoringjob to run local monitoring end-to-end tests as part of PR check workflowFixes # (issue)
Type of change
How has this been tested?
Test Configuration
Checklist 🎯
Additional information
.