Fix failures due to delete experiment #1437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
Signed-off-by: Saad Khan <[email protected]>
|
@khansaad - local monitoring fault tolerant test also needs to be updated |
Signed-off-by: Saad Khan <[email protected]>
bharathappali
requested changes
Dec 23, 2024
| @@ -171,6 +171,14 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response) | |||
| protected void doDelete(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { | |||
| Map<String, KruizeObject> mKruizeExperimentMap = new ConcurrentHashMap<String, KruizeObject>(); | |||
| String inputData = ""; | |||
| String rm = request.getParameter(AnalyzerConstants.ServiceConstants.RM); | |||
| boolean rmTable = false; | |||
There was a problem hiding this comment.
As the if block below is used to just match the value and set the rmTable, we could simplify it with
// Check if rm is not null and set to true
boolean rmTable = (null != rm && AnalyzerConstants.BooleanString.TRUE.equalsIgnoreCase(rm.trim()));
| json_file = open(input_json_file, "r") | ||
| input_json = json.loads(json_file.read()) | ||
|
|
||
| print("\nDeleting the experiment...") | ||
| url = URL + "/createExperiment" | ||
| if rm: |
There was a problem hiding this comment.
As we are relaying on the boolean param which is passed to the function to maintain it's string representation, we can directly use the string representation of the boolean instead of placing a if-else block.
I was suggesting something like this:
PARAMS = {'rm': str(rm).lower()}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
rmflag for the delete experiment API and corresponding test file changesFixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here