This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
28 homework #45
Open
28 homework #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrKalevich
commented
May 30, 2022
AleksandrKalevich
commented
krottv
suggested changes
Jun 5, 2022
| import retrofit2.http.GET | ||
| import retrofit2.http.Query | ||
|
|
||
| object RetrofitBuilder { |
There was a problem hiding this comment.
Синглтон это антипаттерн. Сделай класс (В идеале с интерфейсом) + inject через koin (single)
|
|
||
| override fun onCreate() { | ||
| super.onCreate() | ||
| runBlocking { |
There was a problem hiding this comment.
Нужно создать свою coroutineScope, чтобы не вызывать runBlocking и не блокировать main поток.
CoroutineScope(SupervisorJob() + Dispatchers.Main)
| class HostFragment: Fragment() { | ||
|
|
||
| private lateinit var fragment: HostFragmentBinding | ||
| private val albumsFragment = AlbumsFragment() |
There was a problem hiding this comment.
Создавать фрагмент нужно только, когда savedInstanceState == null. В другом же случае, фрагмент уже будет и его нужно найти при помощи findFragmentByTag("tag"). Тут при смене конфигурации будет 2 фрагмента в памяти. bundle тоже как глобальную переменную лучше не держать. К ней есть доступ через albumsFragment.arguments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.