Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change for python 3.11 aioredis to redis. #12

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

degenhard
Copy link
Contributor

@sanderfoobar
Copy link
Collaborator

sanderfoobar commented Jan 16, 2023

  • what is the significance of Python 3.11? Does this commit not work for lower versions?
  • does this remove the aioredis requirement from setup.py ?

@degenhard
Copy link
Contributor Author

degenhard commented Jan 16, 2023

  • what is the significance of Python 3.11? Does this commit not work for lower versions?

i tested it with 3.7-3.11 and it works. the significance is maybe speed and future proofness (aioredis is now redis), my current project is based on python311 and i need a fix.

https://github.com/redis/redis-py/blob/8592cacf9e5069f8f6d392a2bc02aeade87c9d69/README.md?plain=1#L16
tldr; aioredis is merged into redis package, the current aioredis released package raises
TypeError: duplicate base class TimeoutError

  • does this remove the aioredis requirement from setup.py ?

yes, changed it.

@sanderfoobar
Copy link
Collaborator

I see, thanks 👍 Ill update pypi later today.

@sanderfoobar sanderfoobar merged commit d08156f into kroketio:master Jan 16, 2023
@sanderfoobar
Copy link
Collaborator

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants