Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window improvements #543

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Window improvements #543

merged 2 commits into from
Dec 4, 2024

Conversation

Pedro-Beirao
Copy link
Collaborator

@Pedro-Beirao Pedro-Beirao commented Nov 30, 2024

  • Window can be resized on mac now.
    That comment is no longer accurate on new mac versions.

  • Make sure initial scale is always >= 640x480 on OpenGL
    This was done for software in coelckers/prboom-plus@3a578e6
    Woof has a min size of 480p, in our case, we allow the user to manually reduce the size from 480p to the render size using the mouse
    Addresses Window scaling not accurate in software mode #531

About the "actualheight" code. Do we really want to preserve the aspect ratio problem of old VGA screens? It doesnt even work on opengl.
If someone wants it, then they should play around with the "aspect ratio" option.

@Pedro-Beirao Pedro-Beirao merged commit 22a5e97 into kraflab:master Dec 4, 2024
5 checks passed
@Pedro-Beirao
Copy link
Collaborator Author

I'll bring up that last question some other time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant