Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing async syntax for python 3.7 #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lexadler
Copy link

'async' become reserved keyword in Python 3.7 so variable should be renamed to avoid SyntaxError:

  File "/home/radler/PycharmProjects/ui_testing/env/lib/python3.7/site-packages/pytractor/webdriver.py", line 22, in <module>
    from .mixins import WebDriverMixin
  File "/home/radler/PycharmProjects/ui_testing/env/lib/python3.7/site-packages/pytractor/mixins.py", line 78
    async = kwargs.pop('async', True)
          ^
SyntaxError: invalid syntax

@lexadler
Copy link
Author

lexadler commented Sep 11, 2019

@RemoNova only pytractor code was fixed and no tests were changed with the first commit. Due to that the build was failed. Now tests are fixed and python 3.7 added to Travis for further testing. Builds was passed in my forked repo so everything is ok now.

@remnov
Copy link

remnov commented Sep 11, 2019

@lexadler Yes I saw that.
Unfortunately we need to wait for @kpodl to merge PR.

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main change for this PR:
async -> is_async

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants