Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give appropriate errors for out of order execution related props #713

Merged
merged 20 commits into from
Nov 10, 2024
Merged

Give appropriate errors for out of order execution related props #713

merged 20 commits into from
Nov 10, 2024

Conversation

Rekt3421
Copy link
Contributor

this addresses issues for the failing tests in #710 for the following tests

negative_create_command_queue
negative_create_command_queue_with_properties
negative_create_command_queue_with_properties_khr

rjodinchr
rjodinchr suggested changes Aug 27, 2024
View reviewed changes
src/api.cpp Outdated Show resolved Hide resolved
rjodinchr
rjodinchr reviewed Aug 27, 2024
View reviewed changes
src/config.def Outdated Show resolved Hide resolved
rjodinchr
rjodinchr reviewed Aug 28, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/api.cpp Outdated Show resolved Hide resolved
rjodinchr
rjodinchr reviewed Aug 29, 2024
View reviewed changes
src/config.def Outdated Show resolved Hide resolved
@Rekt3421 @rjodinchr
use bool instead of uint
b618b0d 
Co-authored-by: Romaric Jodin <[email protected]>
rjodinchr
rjodinchr reviewed Sep 2, 2024
View reviewed changes
src/api.cpp Outdated Show resolved Hide resolved
rjodinchr
rjodinchr suggested changes Sep 2, 2024
View reviewed changes
src/api.cpp Outdated Show resolved Hide resolved
src/api.cpp Outdated Show resolved Hide resolved
rjodinchr
rjodinchr reviewed Sep 10, 2024
View reviewed changes
src/api.cpp Outdated Show resolved Hide resolved
rjodinchr
rjodinchr suggested changes Sep 16, 2024
View reviewed changes
src/api.cpp Outdated Show resolved Hide resolved
kpet
kpet approved these changes Nov 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kpet kpet merged commit 99c68d1 into kpet:main Nov 10, 2024
8 checks passed
@kpet kpet mentioned this pull request Nov 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjodinchr rjodinchr rjodinchr approved these changes

@kpet kpet kpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rekt3421 @kpet @rjodinchr