Merge pull request #31 from koyopro/feature/find

Throw a RecordNotFound error when the id passed to find() is not finite.

packages/accel-record-core/src/errors.ts

@@ -0,0 +1 @@
+export class RecordNotFound extends Error {}

packages/accel-record-core/src/query.ts

@@ -1,4 +1,5 @@
-import type { Model } from "./index.js";
+import { RecordNotFound } from "./errors.js";
+import { type Model } from "./index.js";
 import type { Meta } from "./meta.js";
 import { Relation } from "./relation/index.js";
 
@@ -314,11 +315,13 @@ export class Query {
     this: T,
     id: number
   ): Meta<T>["Persisted"] {
-    const instance = this.all()
-      .setOption("wheres", [{ [this.primaryKeys[0]]: id }])
-      .first();
+    const instance = isFinite(id)
+      ? this.all()
+          .setOption("wheres", [{ [this.primaryKeys[0]]: id }])
+          .first()
+      : undefined;
     if (!instance) {
-      throw new Error("Record Not found");
+      throw new RecordNotFound("Record Not Found");
     }
     return instance;
   }

packages/accel-record/package.json

@@ -5,6 +5,16 @@
   "type": "module",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
+  "exports": {
+    ".": {
+      "types": "./dist/index.d.ts",
+      "default": "./dist/index.js"
+    },
+    "./errors": {
+      "types": "./dist/errors.d.ts",
+      "default": "./dist/errors.js"
+    }
+  },
   "scripts": {
     "build": "tsc",
     "test": "vitest",

packages/accel-record/src/errors.ts

@@ -0,0 +1 @@
+export * from "accel-record-core/dist/errors";

tests/models/query.test.ts

@@ -1,3 +1,4 @@
+import { RecordNotFound } from "accel-record/errors";
 import { $post } from "../factories/post";
 import { $user } from "../factories/user";
 import { User } from "./index";
@@ -135,15 +136,20 @@ describe("Query", () => {
   });
 
   test(".find()", () => {
-    expect(() => {
+    try {
       User.find(1);
-    }).toThrow("Record Not found");
-    const u = $user.create({ name: "hoge", email: "[email protected]" });
+    } catch (e) {
+      expect(e).toBeInstanceOf(RecordNotFound);
+    }
+    const u = $user.create({ id: 1, name: "hoge", email: "[email protected]" });
     const s = User.find(u.id!);
     expect(s).toBeInstanceOf(User);
     expect(s.id).toBe(u.id!);
     expect(s.name).toBe("hoge");
     expect(s.email).toBe("[email protected]");
+
+    expect(() => User.find(NaN)).toThrowError("Record Not Found");
+    expect(User.find("1" as any)).toBeInstanceOf(User);
   });
 
   test(".findBy()", () => {