Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added update-if-older-than option #489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danapsimer
Copy link

This option will skip files where the latest version is have been updated since the date provided on the command line.

For example this could be used to update only if the last commit for a file is newer than the latest version in confluence:

mark --space "****" -f $file -u "${MARK_USER}" -p "${MARK_PWD}" -b "${MARK_URL}" --ci --update-if-older-than "$(git --no-pager log -1 --pretty="format:%cI" $file)"

Copy link
Collaborator

@mrueg mrueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're currently relicensing to Apache 2.0 only (before it was CommonsClause). Could you mention that you're okay with this being licensed under Apache 2.0?

@@ -25,7 +25,7 @@ import (
)

const (
version = "10.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase and keep the version?

altsrc.NewStringFlag(&cli.StringFlag{
Name: "update-if-older-than",
Value: "",
Usage: "Update the page only if the last update is older than the specified date.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the format here in which mark expects the date to be in?

@mrueg
Copy link
Collaborator

mrueg commented Aug 30, 2024

I think it would also be nice if we could record your snipped "$(git --no-pager log -1 --pretty="format:%cI" $file) somewhere in the readme :)

@mrueg
Copy link
Collaborator

mrueg commented Sep 4, 2024

One question/caveat:
If my doc is older and it has a reference to another markdown file which changes the title in a later changeset, there will be an inconsistency I guess.

@mrueg
Copy link
Collaborator

mrueg commented Sep 24, 2024

@danapsimer ping, do you have any interest in continuing on this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants