Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for POC #136

Closed
wants to merge 17 commits into from
Closed

Initial commit for POC #136

wants to merge 17 commits into from

Conversation

kotwanikunal
Copy link
Owner

Description

POC for parallel downloads

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kunal Kotwani <[email protected]>
@kotwanikunal kotwanikunal force-pushed the multistream-download-poc branch from f01530b to de65295 Compare August 4, 2023 16:52
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
@kotwanikunal kotwanikunal force-pushed the multistream-download-poc branch from 9f7a6c8 to bf4e464 Compare August 8, 2023 23:43
CompletableFuture<Void> completableFuture = readContextFuture.thenCompose(readContext -> CompletableFuture.runAsync(() -> {
List<InputStream> blobInputStreams = readContext.getBlobInputStreams();
List<String> partFileNames = new ArrayList<>();
for (int streamNumber = 0; streamNumber < blobInputStreams.size(); streamNumber++) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here.

return completableFuture;
}

private void postDownload(Directory segmentDirectory, String fileName, List<String> partFileNames) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stitching here.

@kotwanikunal kotwanikunal requested a review from andrross as a code owner August 14, 2023 17:17
Signed-off-by: Kunal Kotwani <[email protected]>
@kotwanikunal kotwanikunal force-pushed the multistream-download-poc branch from dee73d1 to 602f0fa Compare August 14, 2023 21:30
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant