-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 [FEAT: ] Download code feature #112
Conversation
@amaan-ahmad is attempting to deploy a commit to a Personal Account owned by @kothariji on Vercel. @kothariji first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/kothariji/syntaxmeets/G5dCnYhtpHeKT3ojQJJdJLA8x7X9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amaan-ahmad thanks for the PR 🔥
Things are working great. 🙌 ⭐
The only thing for which I am concerned with is UI
The footer of syntax editor is too poky..All buttons are tightly filled, which is a symbol of Bad UI.
Can you suggest any alternatives for that.
Also any suggestions for the same - @Vishv07 @Priyankcoder @jainaayush01 @AmeyaJain-25 @AyushShri
I think we can go with only icons and on hover we can describe that this options to upload, copy to clipboard, download. |
Yes, @kothariji I agree with what you said, the UI does seem too crowded at the bottom. also, I agree with @jainaayush01 opinion on it. We can remove the text and let alone icons sit there. Another choice would be adding something like this to have an extended list of options available for users to choose from. |
Yes @kothariji , Another way is to use a Modal/Dialog or PopUp to give options to Copy, Download, etc. |
Yes exactly, I feel the same @jainaayush01 @amaan-ahmad @AmeyaJain-25, actually, I think an Issue thread would be a much better place to talk on this 😄. So I have created issue #118 , and we all can discuss it there |
For now, @amaan-ahmad , can you please change thing accordingly
We can merge this PR, once this points are validated |
I think as of now we can just put a download icon there no need to put the whole button than an icon into the button to make some space. or maybe just icons for all the three options except RUN. |
Hey @kothariji |
Sure @amaan-ahmad, but if I merge this PR now, it will move to production, and the syntaxeditor footer won't look good. So if possible can you please do 2 quick changes. So that it will work for now. Because we are not sure how much time #118 will take to resolve Right ?. |
Okay @kothariji How about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions 🔥
Keep contributing 🚀
The feature has been tested successfully for all the currently supported languages
This PR includes:
Closes: #96
Screenshot