Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement operator negation with existence assumption #189

Merged
merged 36 commits into from
Sep 8, 2021

Conversation

thomaskrause
Copy link
Member

@thomaskrause thomaskrause commented Aug 31, 2021

This implements #186 by splitting the current BinaryOperator trait into two traits (one that can only be used with nested loop joins and one that can be used with index joins) and adding an automatic implementation of the negated variant for each existing binary operator. This can only use the filter_match function, since there is no way to automatically find optimized implementations for the negation. A (slow) nested loop join is enforced instead. Since the current implementation of the negated operators are non-binding (as defined in #186), this is not an issue since in most cases this will be an additional filter function and not be used to generate new right-hand-side matches for a given left-hand-side.

TO-DOs

  • Fix issues reported by clippy in the changed files
  • run benchmark to ensure no existing query is affected
  • add specific test queries for the new operator

@thomaskrause thomaskrause marked this pull request as ready for review September 8, 2021 10:51
@thomaskrause
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 8, 2021

@bors bors bot merged commit 10a23e7 into develop Sep 8, 2021
@thomaskrause thomaskrause deleted the feature/negated-operators branch September 9, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator negation in AQL - part 1: negation with existence assumption
1 participant