HT4 by Balioura #38
Open
HT4 by Balioura #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Jan 12, 2021
| }; | ||
|
|
||
| export default connect((state) => ({ | ||
| allReviews: state.reviews, |
koretskiyav
reviewed
Jan 12, 2021
|
|
||
| const AverageRate = ({ reviews, allReviews }) => { | ||
|
|
||
| const averageRating = useMemo(() => { |
There was a problem hiding this comment.
все эти вычисления нужно выносить в селекторы, чтобы компонент занимался только рендером
koretskiyav
reviewed
Jan 12, 2021
| @@ -5,7 +5,7 @@ import Restaurant from '../restaurant'; | |||
| import Tabs from '../tabs'; | |||
|
|
|||
| const Restaurants = ({ restaurants }) => { | |||
| const tabs = restaurants.map((restaurant) => ({ | |||
| const tabs = Object.values(restaurants).map(restaurant => ({ | |||
There was a problem hiding this comment.
это тоже должно быть в селекторах и мемоизировано
koretskiyav
reviewed
Jan 12, 2021
|
|
||
| export const increment = (id) => ({ type: INCREMENT, payload: { id } }); | ||
| export const decrement = (id) => ({ type: DECREMENT, payload: { id } }); | ||
| export const remove = (id) => ({ type: REMOVE, payload: { id } }); | ||
| export const addReview = (item) => ({ type: ADD_REVIEW, payload: item }); |
There was a problem hiding this comment.
тут можно (и нужно) обойтись одним екшеном, т.к. все редьюсеры реагирую на все екшены, я на занятии расскажу в чем проблемы такого подхода
koretskiyav
reviewed
Jan 12, 2021
|
|
||
| if (action.type === 'ADD_REVIEW' || action.type === 'ADD_USER') { | ||
| const uuid = uuidv4(); | ||
| action.payload = { |
There was a problem hiding this comment.
не стоит мутировать action, лучше создать новый
koretskiyav
reviewed
Jan 12, 2021
| <div className={styles.review} data-id="review"> | ||
| <div className={styles.content}> | ||
| <div> | ||
| <h4 className={styles.name} data-id="review-user"> | ||
| {user} | ||
| {userName} {/* // это лучше отдельным компонентом? */} |
koretskiyav
reviewed
Jan 12, 2021
| Review.defaultProps = { | ||
| user: 'Anonymous', | ||
| const mapStateToProps = (state, ownProps) => { | ||
| const review = state.reviews[ownProps.id]; |
There was a problem hiding this comment.
все это нужно выносить в селекторы, чтобы компонент занимался только рендером
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.