Add on-segment mode for pg_dump utility #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kooooootb
force-pushed
the
gp_dump
branch
2 times, most recently
from
fb0dd2c
to
43fac53
Compare
This mode is used to save data on each segment locally part by part
andr-sokolov
reviewed
Jun 2, 2024
| if (compressLevel != 0) | ||
| return runRestore_CompressedPlainText(inputFileSpec); | ||
| #endif | ||
| else |
There was a problem hiding this comment.
wanted to make it clear but ok, done
| ropt = NewRestoreOptions(); | ||
| ropt->filename = inputFileSpec; | ||
|
|
||
| if (compressLevel == -1) |
There was a problem hiding this comment.
Let's make the code simpler using ternary operator: ropt->compression = (compressLevel == -1) ? 0 : compressLevel;
| static void | ||
| setupDumpWorkerDummy(Archive *AH, RestoreOptions *ropt) | ||
| { | ||
| } |
There was a problem hiding this comment.
Let's add newline at the end of file here and below to make github happy
|
|
||
| ((ArchiveHandle *)AH)->ropt = ropt; | ||
|
|
||
| if (plainText) |
There was a problem hiding this comment.
Can we use format == archNull in this condition and remove the plainText variable?
andr-sokolov
reviewed
Jun 2, 2024
| const int bufferSize = 1024; | ||
| const char *buffer[bufferSize]; | ||
|
|
||
| size_t readLen = 0; |
There was a problem hiding this comment.
0 is never used. The readLen value is changed in the next line
kuhella
reviewed
Jun 11, 2024
| extern int onSegmentHelper_RunRestore(const char *inputFileSpec, int compressLevel, ArchiveFormat format); | ||
| extern int onSegmentHelper_RunDump(const char *inputFileSpec, int compressLevel, ArchiveFormat format); | ||
|
|
||
| #endif // PG_DUMP_SEGMENT_HELPER |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pg_dump on-segment mode, where data is stored locally on segments
This mode gets activated by using --on-segment flag, it generates dump on client side as usual and data dumps on each used segment, compression level and archive formats are forwarded to segments' archives
Generated dump can be used by pg_restore or psql (for plain texts) as usual
Also to manage data on segments 2 other system modes were added.
First one (--on-segment-internal-dump-mode) reads data from stdin to stores it locally with forwarded archive format and compression level.
Second (--on-segment-internal-restore-mode) reads stored data and passes it to stdout
In this mode utility uses COPY ... TO PROGRAM ... ON SEGMENT instead of normal COPY and passes output of it to pg_dump on each segment.
To restore data it saves COPY ... FROM PROGRAM ... ON SEGMENT operators to final dump, which read data from utility on each segment.