Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #88 and add zipfile test #103

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Fix #88 and add zipfile test #103

merged 4 commits into from
Jan 21, 2021

Conversation

jrideout
Copy link
Collaborator

backs out the pathlib change in #88 (which didn't quite work and requires py3.9) and added a test file for the duplicate filename in a zip case

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #103 (8a4a519) into master (e874f08) will increase coverage by 0.22%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   95.97%   96.20%   +0.22%     
==========================================
  Files           7        7              
  Lines        1292     1290       -2     
  Branches      120      120              
==========================================
+ Hits         1240     1241       +1     
+ Misses         36       34       -2     
+ Partials       16       15       -1     
Impacted Files Coverage Δ
tnefparse/util.py 90.47% <0.00%> (ø)
tnefparse/mapi.py 81.32% <100.00%> (+0.11%) ⬆️
tnefparse/tnef.py 95.25% <100.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e874f08...8a4a519. Read the comment docs.

@jrideout jrideout merged commit 533aded into master Jan 21, 2021
@jrideout jrideout deleted the refactor2 branch January 21, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants