Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Perform minimal structural improvements #17

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

abrugaro
Copy link
Collaborator

Performed minimal structural improvements for the repository that include:

  • Renamed LaunchVSCodePage class and launchVSCode method to better reflect the current behaviour
  • Added quotes to installExtensionFromVSIX method to support path with whitespaces
  • Added test script to the packages.json file
  • Removed the explicit call to the close method as Playwright automatically closes the app once all the tests are finished
  • Disabled the fully parallel execution of tests since the two tests of the file depends on the first test opening VSCode (parallelization is still enabled for different files)
  • Added output folders, .env file and node_modules to the .gitignore
  • Other minor improvements

Signed-off-by: Alejandro Brugarolas <[email protected]>
@abrugaro abrugaro changed the title ✨ Perform minimal structural improvements 🌱 : Perform minimal structural improvements Oct 21, 2024
@abrugaro abrugaro changed the title 🌱 : Perform minimal structural improvements 🌱 Perform minimal structural improvements Oct 21, 2024
@sshveta sshveta merged commit d648f36 into konveyor:main Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants