Бочаров Александр #246
Open
Бочаров Александр #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Folleach
reviewed
Dec 11, 2024
Comment on lines
+9
to
+11
| var numberEnumerable = text | ||
| .Skip(begin) | ||
| .TakeWhile(CanScan); |
There was a problem hiding this comment.
На сколько я понял, в text всегда заходит оригинальный текст.
Удовлетворяет ли Skip сложности O(n) в таком случае?
Красивее было реализовать ITokenScanner с использованием ссылки на кусок текста. В C# для этого существуюет Span<T>
Сделаешь?
Тогда не понадобится сохранять контекст дополнительными параметрами вроде begin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.