Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): various terraform tweaks #712

Merged
merged 3 commits into from
Mar 28, 2024
Merged

feat(terraform): various terraform tweaks #712

merged 3 commits into from
Mar 28, 2024

Conversation

FalcoSuessgott
Copy link
Contributor

@FalcoSuessgott FalcoSuessgott commented Mar 7, 2024 •
edited
Loading

  • avoided depends_on in all vault modules
  • run terraform format for all terraform dirs.
  • added a Makefile with fmt and validate target to perform these options conviently locally ( make validate catched some errors and warning that we might wanna fix in another PR.)
  • Added terraform format recursive option in CI.
  • metaphore secrets are now created using a single vault_generic_secret block using for_each, so its less redundant

This PR is ready for review, would love some feedback if somebody has the time and patience

@FalcoSuessgott FalcoSuessgott changed the title fix(terraform): terraform fmt & avoid depends_on fix(terraform): minor terraform tweaks Mar 7, 2024
@FalcoSuessgott FalcoSuessgott changed the title fix(terraform): minor terraform tweaks feat(terraform): minor terraform tweaks Mar 7, 2024
@FalcoSuessgott FalcoSuessgott marked this pull request as draft March 7, 2024 05:13
@FalcoSuessgott FalcoSuessgott marked this pull request as ready for review March 16, 2024 12:25
@FalcoSuessgott FalcoSuessgott changed the title feat(terraform): minor terraform tweaks feat(terraform): various terraform tweaks Mar 16, 2024
@fharper
Copy link
Contributor

fharper commented Mar 27, 2024

@FalcoSuessgott sorry for the wait, I was away, and the team is swamped. Thanks a lot for your contribution to kubefirst!

I'll ask the engineering team to review your PR, but can you please sign your commits please https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits as we won't be able to merge them without it.

@FalcoSuessgott
Copy link
Contributor Author

FalcoSuessgott commented Mar 28, 2024 •
edited
Loading

Hi @fharper! aprreciate your time. Signed all commits now and rebased against main :)

jarededwards
jarededwards approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@jarededwards jarededwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @FalcoSuessgott !

@fharper fharper merged commit c4e0be3 into konstructio:main Mar 28, 2024
2 checks passed
@fharper
Copy link
Contributor

fharper commented Mar 28, 2024

Thanks @FalcoSuessgott: if you want to DM me on our Slack community, I'll send you some swag as a small thank you gesture for your PR!

@FalcoSuessgott FalcoSuessgott mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarededwards jarededwards jarededwards approved these changes

Assignees

@FalcoSuessgott FalcoSuessgott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FalcoSuessgott @fharper @jarededwards