Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW2 #4

Merged
merged 13 commits into from
Dec 4, 2023
Merged

HW2 #4

merged 13 commits into from
Dec 4, 2023

Conversation

konnnst
Copy link
Owner

@konnnst konnnst commented Sep 27, 2023

Write own non thread safe and thread safe realisations of built-in Lazy class

Copy link

@ArtyomKopan ArtyomKopan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Итого 4 балла. Нужно доработать тесты

HW02LAZY/LAZY/Lazy.cs Outdated Show resolved Hide resolved
HW02LAZY/LAZY/Lazy.cs Outdated Show resolved Hide resolved
HW02LAZY/LAZY/Lazy.cs Outdated Show resolved Hide resolved
HW02LAZY/LAZY/Lazy.cs Outdated Show resolved Hide resolved
HW02LAZY/LAZY/Lazy.cs Outdated Show resolved Hide resolved
HW02LAZY/LazyTests/LazyTests.cs Outdated Show resolved Hide resolved
HW02LAZY/LazyTests/LazyTests.cs Outdated Show resolved Hide resolved
@konnnst konnnst requested a review from ArtyomKopan October 13, 2023 20:51
Copy link

@ArtyomKopan ArtyomKopan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.5/5. Стоит добавить обработку и хранение исключений в Lazy (вдруг вычисление произойдёт некорректно?)

@konnnst konnnst requested a review from ArtyomKopan October 26, 2023 08:47
@konnnst konnnst requested review from ArtyomKopan and removed request for ArtyomKopan November 4, 2023 09:18
Copy link

@ArtyomKopan ArtyomKopan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё отлично, 5/5!

Comment on lines +111 to +116
internal class MyLazy
{
static void Main()
{
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот это лучше удалить, зачем нам пустые классы?

@konnnst konnnst merged commit db82602 into master Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants