fix(RELEASE-1345): avoid failing on invalid purl string #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
reviewed
Dec 13, 2024
johnbieren
reviewed
Dec 13, 2024
johnbieren
reviewed
Dec 13, 2024
The sboms can contain invalid non-rpm purl strings and we would fail on parsing them using the packageurl module. Avoid these failures by parsing the purl type in our own function and only pass it to packageurl if it's an rpm purl. Otherwise skip it. Signed-off-by: Martin Malina <[email protected]>
johnbieren
approved these changes
Dec 13, 2024
mmalina
added a commit
to mmalina/release-service-catalog
that referenced
this pull request
Dec 16, 2024
The new image contains a fix to avoid failing on invalid purl strings. See this related PR: konflux-ci/release-service-utils#343 Signed-off-by: Martin Malina <[email protected]>
Merged
4 tasks
mmalina
added a commit
to mmalina/release-service-catalog
that referenced
this pull request
Dec 16, 2024
The new image contains a fix to avoid failing on invalid purl strings. See this related PR: konflux-ci/release-service-utils#343 Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to mmalina/release-service-catalog
that referenced
this pull request
Dec 16, 2024
The new image contains a fix to avoid failing on invalid purl strings. See this related PR: konflux-ci/release-service-utils#343 Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to mmalina/release-service-catalog
that referenced
this pull request
Dec 16, 2024
The new image contains a fix to avoid failing on invalid purl strings. See this related PR: konflux-ci/release-service-utils#343 Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to mmalina/release-service-catalog
that referenced
this pull request
Dec 16, 2024
The new image contains a fix to avoid failing on invalid purl strings. See this related PR: konflux-ci/release-service-utils#343 Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to konflux-ci/release-service-catalog
that referenced
this pull request
Dec 17, 2024
The new image contains a fix to avoid failing on invalid purl strings. See this related PR: konflux-ci/release-service-utils#343 Signed-off-by: Martin Malina <[email protected]>
midnightercz
pushed a commit
to midnightercz/release-service-catalog
that referenced
this pull request
Jan 3, 2025
The new image contains a fix to avoid failing on invalid purl strings. See this related PR: konflux-ci/release-service-utils#343 Signed-off-by: Martin Malina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sboms can contain invalid non-rpm purl strings and we would fail on parsing them using the packageurl module.
Avoid these failures by parsing the purl type in our own function and only pass it to packageurl if it's an rpm purl. Otherwise skip it.