fix: handle none-type values more carefully #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event that an image does not have any gzipped layers, then no uncompressed layer information will be handed to this tool and it will pass on the None value to pyxis. That fails pyxis' input validation, blocking containerImage creation. In this change, simply drop these values if they happen to be none. Signed-off-by: Ralph Bean <[email protected]>
ralphbean
force-pushed
the
careful-with-none-values
branch
from
0eea308 to
0769f58
Compare
|
Apologies for the heavy hand, but I'm going to merge this one without review. Working on a late-breaking blocker. |
ralphbean
added a commit
to konflux-ci/release-service-catalog
that referenced
this pull request
Nov 11, 2024
The purpose is to pull in this change: konflux-ci/release-service-utils#311 It makes it so that in the event that the layer data is absent, a `null` value won't be sent to pyxis which would be rejected by pyxis' input validation.
ralphbean
added a commit
to konflux-ci/release-service-catalog
that referenced
this pull request
Nov 11, 2024
Do not merge. This is a temporary pipeline to for rpm-ostree images. The image update here pulls in this change: konflux-ci/release-service-utils#311 It makes it so that in the event that the layer data is absent, a `null` value won't be sent to pyxis which would be rejected by pyxis' input validation.
|
Ticket for tests https://issues.redhat.com/browse/RELEASE-1289 |
scoheb
pushed a commit
to scoheb/release-service-catalog
that referenced
this pull request
Nov 28, 2024
Do not merge. This is a temporary pipeline to for rpm-ostree images. The image update here pulls in this change: konflux-ci/release-service-utils#311 It makes it so that in the event that the layer data is absent, a `null` value won't be sent to pyxis which would be rejected by pyxis' input validation.
scoheb
pushed a commit
to konflux-ci/release-service-catalog
that referenced
this pull request
Nov 28, 2024
Do not merge. This is a temporary pipeline to for rpm-ostree images. The image update here pulls in this change: konflux-ci/release-service-utils#311 It makes it so that in the event that the layer data is absent, a `null` value won't be sent to pyxis which would be rejected by pyxis' input validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that an image does not have any gzipped layers, then no uncompressed layer information will be handed to this tool and it will pass on the None value to pyxis. That fails pyxis' input validation, blocking containerImage creation.
In this change, simply drop these values if they happen to be none.