chore(RHTAPWATCH-819): Resolve kube-lint errors #13
Conversation
hmariset
force-pushed
the
resolve-kubelint-errors
branch
3 times, most recently
from
0ff2f99 to
edfd123
Compare
hmariset
force-pushed
the
resolve-kubelint-errors
branch
3 times, most recently
from
a6cb600 to
a9ced27
Compare
|
@ifireball I have updated controller image in kustomization file. Please review again. |
config/manager/kustomization.yaml
Outdated
|
|
||
| images: | ||
| - name: controller | ||
| newName: quay.io/redhat-appstudio/project-controller |
There was a problem hiding this comment.
I think this should reside in the infra-deployments repo, not here.
There was a problem hiding this comment.
I checked image-controller repo and they have it here and when I give this commit sha in infra-deployments the kube-linter errors are resolved.
There was a problem hiding this comment.
@ifireball This is the PR in infra-deployments where the commit sha from here would be updated automatically after we have release plan admission setup.
There was a problem hiding this comment.
This name configuration is specific to the Red Hat deployment, it shouldn't be here. It didn't use to matter for the repos in redhat-appstudio, but now in knoflux-ci it does. We need to make an effort to put the Red Hat specific stuff in infra-deployments if we can.
hmariset
force-pushed
the
resolve-kubelint-errors
branch
from
a9ced27 to
90ed57f
Compare
ifireball
changed the title
hmariset
force-pushed
the
resolve-kubelint-errors
branch
from
90ed57f to
ea86979
Compare
When adding project-controller component to the infra- deployments repository it is failing due to kube-linter issues. Signed-off-by: Homaja Marisetty <[email protected]>
Set the controller image name to something more specific then "controller" but not as specific as what we've set for it when testing with CRC. This is so we can override the name with the real image name in cluster-specific configuration repos. Signed-off-by: Barak Korren <[email protected]>
ifireball
force-pushed
the
resolve-kubelint-errors
branch
from
ea86979 to
8a2c067
Compare
When adding project-controller component to the infra- deployments repository it is failing due to kube-linter issues.