add status of ended pipelinerun to the log #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the status of ended pipelinerun to the log Signed-off-by: Avi Biton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking the logs in staging I found several pipelineruns that did not send notifications.
Those pipelineruns ended not successfully and do not need to send message.
Adding the status of ended pipelinerun to the log to better understand from the logs whether a message should be sent or not, very effective after pipelineruns are deleted and we have no way of knowing they failed.
Logs will look like:
2024-08-08T08:25:26Z INFO Notification controller Pipelinerun ended {"pipelinerun": "dummy-push-pipelinerun-2qkt5", "ended_successfully": true}2024-08-08T08:27:08Z INFO Notification controller Pipelinerun ended {"pipelinerun": "dummy-push-pipelinerun-4dqlg", "ended_successfully": false}