Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KONFLUX-5886): allow unselecting default context #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CryptoRodeo
Copy link
Contributor

The user should be able to unselect the default context during the creation of an integration test.

Other changes:

  • Contexts are now required (at least one)

@CryptoRodeo
Copy link
Contributor Author

Demo of the following:

  • default context can now be unselected (main bug fixed)
  • contexts are now required by the form and modal (at least 1 must be selected).
konflux-5886.mp4

@CryptoRodeo CryptoRodeo force-pushed the konflux-5886 branch 2 times, most recently from 9d36d95 to eb33e13 Compare December 18, 2024 21:10
@CryptoRodeo CryptoRodeo marked this pull request as ready for review December 18, 2024 21:16
@CryptoRodeo CryptoRodeo self-assigned this Dec 18, 2024
@CryptoRodeo
Copy link
Contributor Author

It appears that the code coverage step fails:

error - 2024-12-18 21:48:17,362 -- Report creating failed: {"message":"Token required because branch is protected"}
Error: Codecov:
                        Failed to properly create report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

@testcara
Copy link
Contributor

I met the same token problem for my ci jobs but after 2 days later, retry fixed the problem. It seems the ci is not very stable for this part.

@testcara
Copy link
Contributor

LGTM

The user should be able to unselect the default context during the
creation of an integration test.

Other changes:
- Contexts are now required (at least one)

Signed-off-by: Bryan Ramos <[email protected]>
@JoaoPedroPP
Copy link
Contributor

LGTM

@CryptoRodeo CryptoRodeo added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants