-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KONFLUX-5886): allow unselecting default context #58
Open
CryptoRodeo
wants to merge
1
commit into
konflux-ci:main
Choose a base branch
from
CryptoRodeo:konflux-5886
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo of the following:
konflux-5886.mp4 |
CryptoRodeo
force-pushed
the
konflux-5886
branch
2 times, most recently
from
December 18, 2024 21:10
9d36d95
to
eb33e13
Compare
CryptoRodeo
force-pushed
the
konflux-5886
branch
from
December 18, 2024 21:38
eb33e13
to
8c1f7d9
Compare
It appears that the code coverage step fails:
|
I met the same token problem for my ci jobs but after 2 days later, retry fixed the problem. It seems the ci is not very stable for this part. |
LGTM |
The user should be able to unselect the default context during the creation of an integration test. Other changes: - Contexts are now required (at least one) Signed-off-by: Bryan Ramos <[email protected]>
CryptoRodeo
force-pushed
the
konflux-5886
branch
from
December 19, 2024 14:04
8c1f7d9
to
fcd4962
Compare
LGTM |
JoaoPedroPP
approved these changes
Jan 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user should be able to unselect the default context during the creation of an integration test.
Other changes: