Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(KFLUXUI-254): add two new build pipeline types for maven-zip-build #57

Closed
wants to merge 1 commit into from

Conversation

testcara
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/KFLUXUI-254

Description

We have 2 new more build pipelines. They are maven-zip-build and maven-zip-build-oci-ta. UI needs to cover them.

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

  1. UI should list the new build pipeline types and user can select them well.
Screenshot 2024-12-18 at 16 01 49
  1. And when we select the new build pipeline for our component, the annotation should be changed accordingly.
Screenshot 2024-12-18 at 15 58 23 Screenshot 2024-12-18 at 16 04 07

How to test or reproduce?

  1. create one component and select the new pipeline type
  2. check the annotation of them

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (61e9ed9) to head (3abf9d3).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
.../ImportForm/PipelineSection/usePipelineTemplate.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   79.94%   79.94%           
=======================================
  Files         568      568           
  Lines       21331    21331           
  Branches     5278     5286    +8     
=======================================
  Hits        17054    17054           
  Misses       4252     4252           
  Partials       25       25           
Flag Coverage Δ
unittests 79.94% <85.71%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +32 to +41
{
name: 'maven-zip-build',
bundle:
'quay.io/konflux-ci/tekton-catalog/pipeline-maven-zip-build:84b3cd21b9cc194838dd310fedcc316ea8a4aab4',
},
{
name: 'maven-zip-build-oci-ta',
bundle:
'quay.io/konflux-ci/tekton-catalog/pipeline-maven-zip-build-oci-ta:84b3cd21b9cc194838dd310fedcc316ea8a4aab4',
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will cause these pipeline definitions to appear on all the clusters not just internal clusters. We should wait for https://issues.redhat.com/browse/KFLUXUI-9.

Copy link
Contributor Author

@testcara testcara Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the issue status. For the patch, how about we close it or mark it as draft for waiting?

@testcara testcara changed the title feat(KFLUXUI-254): add two new build pipeline types for maven-zip-build Draft: feat(KFLUXUI-254): add two new build pipeline types for maven-zip-build Jan 10, 2025
@testcara testcara changed the title Draft: feat(KFLUXUI-254): add two new build pipeline types for maven-zip-build [WIP] feat(KFLUXUI-254): add two new build pipeline types for maven-zip-build Jan 10, 2025
@testcara testcara closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants