fix(KFLUXUI-253): tekton results should filter unknown status record out #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testcara
force-pushed
the
KFLUXUI-253
branch
2 times, most recently
from
6cf087c to
cfa1ecd
Compare
|
/retest |
testcara
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
========================================
Coverage 79.94% 79.95%
========================================
Files 568 568
Lines 21331 21335 +4
Branches 5278 5029 -249
========================================
+ Hits 17054 17058 +4
- Misses 4252 4253 +1
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
testcara
force-pushed
the
KFLUXUI-253
branch
2 times, most recently
from
e2a2348 to
0b59a41
Compare
testcara
force-pushed
the
KFLUXUI-253
branch
from
0b59a41 to
7c5062b
Compare
testcara
requested review from
caugello,
CryptoRodeo,
sahil143 and
JoaoPedroPP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://issues.redhat.com/browse/KFLUXUI-253
Description
When we delete one pipeline task run manually before it is completed,UI should not always keep the obsoleted run there. This patch would ignore the meaningless unknown tekton results to ensure there is no deleted but 'in process' runs on UI.
Type of change
Screen shots / Gifs for design review
Without the patch, the UI would list deleted 'running' pipelineruns.
With the patch, the UI would ignore the deleted 'running' pipelineruns.
How to test or reproduce?
Browser conformance: