Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo on sast-snyk-check-oci-ta #1762

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avisiedo
Copy link

If statement to select the media type had a typo, so the condition would be always false. This change would fix potential wrong media types.

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@avisiedo avisiedo changed the title fix: typo on sast-sny-check-oci-ta fix: typo on sast-snyk-check-oci-ta Dec 16, 2024
@zregvart
Copy link
Member

Thanks, this change needs to go to, ideally first, to

if [ "${UPLOAD_FILES}" == "excluded-findings.json" ]; then
as well. Then run hack/generate-ta-tasks.sh to generate this file as it is auto-generated from it.

@avisiedo avisiedo force-pushed the sast-snyk-check-oci-ta--typo branch from fe2ea44 to 25f9ff4 Compare December 17, 2024 08:17
@avisiedo
Copy link
Author

@zregvart thanks for the comment, I was not aware about it 👍 I have updated the base task, and used the script to generate the -oci-ta one!

If statement to select the media type had a typo, so
the condition would be always false. This change would
fix potential wrong media types.

Signed-off-by: Alejandro Visiedo <[email protected]>
@avisiedo avisiedo force-pushed the sast-snyk-check-oci-ta--typo branch from 25f9ff4 to 8d4ec88 Compare December 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants