Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renovate.json groupings #1747

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

chmeliik
Copy link
Contributor

https://docs.renovatebot.com/configuration-options/#packagerules

If multiple matchers are included in one package rule, all of them
must match.

Remove the extraneous matchers that are breaking the groupings

Tested with

$ podman run --rm -ti -v "$PWD:$PWD:z" -w "$PWD" --user=0 \
    -e LOG_LEVEL=debug \
    -e RENOVATE_PLATFORM=local \
    ghcr.io/renovatebot/renovate |
        grep 'Returning .* branch'

  DEBUG: Returning 15 branch(es) (repository=local)

In main, this returns 24 branches instead.

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

https://docs.renovatebot.com/configuration-options/#packagerules

> If multiple matchers are included in one package rule, *all of them*
> must match.

Remove the extraneous matchers that are breaking the groupings

Tested with

    $ podman run --rm -ti -v "$PWD:$PWD:z" -w "$PWD" --user=0 \
        -e LOG_LEVEL=debug \
        -e RENOVATE_PLATFORM=local \
        ghcr.io/renovatebot/renovate |
            grep 'Returning .* branch'

      DEBUG: Returning 15 branch(es) (repository=local)

In main, this returns 24 branches instead.

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik chmeliik requested a review from a team as a code owner December 11, 2024 10:26
@chmeliik
Copy link
Contributor Author

Kudos @tnevrlka for finding If multiple matchers are included in one package rule, all of them must match.

@chmeliik chmeliik added this pull request to the merge queue Dec 11, 2024
Merged via the queue into konflux-ci:main with commit 58950bb Dec 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants