feat: enable multi-arch fbc verification #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arewm
force-pushed
the
validate-fbc-return-images-processed
branch
4 times, most recently
from
f468540 to
ec94719
Compare
While the FBC builder pipeline has been changed to be multi-arch aware, the validate-fbc task will cause EC failures since it does not report that the results are valid for all of the OCI image manifest digests. Even if we are not performing additional verification on the architecture specific images, we need to set the IMAGES_PROCESSED result so that EC will pass. Signed-off-by: arewm <[email protected]>
arewm
force-pushed
the
validate-fbc-return-images-processed
branch
from
ec94719 to
6e9fb2f
Compare
Josh-Everett
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the FBC builder pipeline has been changed to be multi-arch aware, the validate-fbc task will cause EC failures since it does not report that the results are valid for all of the OCI image manifest digests. Even if we are not performing additional verification on the architecture specific images, we need to set the IMAGES_PROCESSED result so that EC will pass.