Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KONFLUX-6026): remove duplicate @sha256 from inspection #1733

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

arewm
Copy link
Member

@arewm arewm commented Dec 9, 2024

When determining the BASE_IMAGE for inspections, we didn't properly remove the tags and digests before appending the detected digest of the referenced images.

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@arewm arewm requested a review from a team as a code owner December 9, 2024 14:58
vdemeester added a commit to vdemeester/openshift-pipelines-operator that referenced this pull request Dec 9, 2024
vdemeester added a commit to vdemeester/openshift-pipelines-operator that referenced this pull request Dec 9, 2024
When determining the BASE_IMAGE for inspections, we didn't properly
remove the tags and digests before appending the detected digest of the
referenced images.

Signed-off-by: arewm <[email protected]>
@arewm
Copy link
Member Author

arewm commented Dec 9, 2024

The linked PR testing this change (openshift-pipelines/operator#913) successfully completed the validate-fbc task.

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arewm arewm enabled auto-merge December 9, 2024 15:56
@chipspeak chipspeak self-requested a review December 9, 2024 16:05
Copy link
Contributor

@chipspeak chipspeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arewm
Copy link
Member Author

arewm commented Dec 9, 2024

I suspect that the e2e tests will time out due to cluster slowness this morning.

@arewm arewm added this pull request to the merge queue Dec 9, 2024
Merged via the queue into konflux-ci:main with commit fea7923 Dec 9, 2024
16 checks passed
@arewm arewm deleted the konflux-6026 branch December 10, 2024 01:51
vdemeester added a commit to vdemeester/openshift-pipelines-operator that referenced this pull request Dec 10, 2024
vdemeester added a commit to openshift-pipelines/operator that referenced this pull request Dec 10, 2024
pramodbindal pushed a commit to pramodbindal/operator that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants