-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KONFLUX-6026): remove duplicate @sha256 from inspection #1733
Conversation
See konflux-ci/build-definitions#1733 Signed-off-by: Vincent Demeester <[email protected]>
See konflux-ci/build-definitions#1733 Signed-off-by: Vincent Demeester <[email protected]>
When determining the BASE_IMAGE for inspections, we didn't properly remove the tags and digests before appending the detected digest of the referenced images. Signed-off-by: arewm <[email protected]>
The linked PR testing this change (openshift-pipelines/operator#913) successfully completed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I suspect that the e2e tests will time out due to cluster slowness this morning. |
See konflux-ci/build-definitions#1733. Signed-off-by: Vincent Demeester <[email protected]>
See konflux-ci/build-definitions#1733. Signed-off-by: Vincent Demeester <[email protected]>
See konflux-ci/build-definitions#1733. Signed-off-by: Vincent Demeester <[email protected]>
When determining the BASE_IMAGE for inspections, we didn't properly remove the tags and digests before appending the detected digest of the referenced images.
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.