Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPDX sbom support for buildah tasks [CLOUDDST-24218] #1542

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SPDX sbom support for buildah tasks [CLOUDDST-24218] #1542

wants to merge 2 commits into from
+140 −50

Conversation

midnightercz
Copy link

@midnightercz midnightercz commented Oct 30, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested review from MartinBasti and rcerven October 30, 2024 15:09
@chmeliik
Copy link
Contributor

@midnightercz in all your SPDX PRs, could you please comment the PRs they depend on (starting with konflux-ci/architecture#213)? It's getting hard to keep track of them 🙂

@chmeliik
Copy link
Contributor

Oh, and please keep them in draft until their dependencies are merged

@midnightercz
Copy link
Author

Oh, and please keep them in draft until their dependencies are merged

The change is conceived to be ready to merge. If you check the code there's condition which makes relevant steps fail if sbomType is set to spdx. So either this can be merge and condition removed later or we can merge it once all deps are merged and released. Anyway, I would like this to be tested by CI in the current state as locally I can discover only some problems.
I'll add the links to the description

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBasti MartinBasti Awaiting requested review from MartinBasti

@rcerven rcerven Awaiting requested review from rcerven

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@midnightercz @chmeliik @openshift-merge-robot