tasks: Use set -e in rpm-ostree task #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to https://gitlab.com/redhat/centos-stream/containers/bootc/-/merge_requests/248 Basically a while ago the rpm-ostree task was forked from the buildah task and we didn't inherit the later change to use `set -e` (as we should) on the inner shell script, meaning we had the default "blindly stumble forward when we hit an error" which is never what we want. This would have helped focus the problem on cachi2, not selinux. Signed-off-by: Colin Walters <[email protected]>
arewm
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://gitlab.com/redhat/centos-stream/containers/bootc/-/merge_requests/248
Basically a while ago the rpm-ostree task was forked from the buildah task and we didn't inherit the later change to use
set -e(as we should) on the inner shell script, meaning we had the default "blindly stumble forward when we hit an error" which is never what we want.This would have helped focus the problem on cachi2, not selinux.