fix: oci-copy task triggers unbounded var error when not using AWS creds #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested my changes in a PR, it fixes my issue. I haven't tested if it introduces regression |
|
/ok-to-test |
chmeliik
reviewed
Oct 7, 2024
Signed-off-by: Matthieu Bernardin <[email protected]>
pastequo
force-pushed
the
fix/oci-copy-task
branch
from
7e23188 to
44d46b8
Compare
|
@chmeliik Should be done as well. I haven't checked the rest of the file... |
ralphbean
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some build is failing because of this.
I think the problem is that set -u is set after the function definition but before the function is called
EDIT: I'm talking about this set: https://github.com/konflux-ci/build-definitions/blob/main/task/oci-copy/0.1/oci-copy.yaml#L186
Build is failing because of
When I'm not providing AWS creds