chore(RHTAPWATCH-1297): Add rpms-signature-scan to template #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge #1482 before merging this PR. |
Add rpms-signature-scan to template Signed-off-by: Avi Biton <[email protected]>
|
#1482 was merged. |
mmorhun
reviewed
Sep 30, 2024
| @@ -265,7 +265,21 @@ spec: | |||
| workspaces: | |||
| - name: workspace | |||
| workspace: workspace | |||
|
|
|||
| - name: rpms-signature-scan | |||
There was a problem hiding this comment.
Do we really need this task for all pipelines and all users?
There was a problem hiding this comment.
I believe so. It's how Konflux will be able to enforce that all included RPMs are signed with the right key via EC.
There was a problem hiding this comment.
Yes, @mmorhun thats the feature.
This is the refinement doc
This is the feature
lcarva
approved these changes
Sep 30, 2024
arewm
added a commit
to arewm/build-definitions
that referenced
this pull request
Oct 18, 2024
In konflux-ci#1480, we added the rpms-signature-scan task to the pipeline template. This resulted in the task being added to multiple pipelines unnecessarily. Signed-off-by: arewm <[email protected]>
arewm
added a commit
to arewm/build-definitions
that referenced
this pull request
Oct 18, 2024
In konflux-ci#1480, we added the rpms-signature-scan task to the pipeline template. This resulted in the task being added to multiple pipelines unnecessarily. Also removed additional unnecessary tasks from the tekton bundle builder pipeline. Signed-off-by: arewm <[email protected]>
arewm
added a commit
to arewm/build-definitions
that referenced
this pull request
Oct 18, 2024
In konflux-ci#1480, we added the rpms-signature-scan task to the pipeline template. This resulted in the task being added to multiple pipelines unnecessarily. Also removed additional unnecessary tasks from the tekton bundle builder pipeline. Signed-off-by: arewm <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
In #1480, we added the rpms-signature-scan task to the pipeline template. This resulted in the task being added to multiple pipelines unnecessarily. Also removed additional unnecessary tasks from the tekton bundle builder pipeline. Signed-off-by: arewm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rpms-signature-scan
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.