tekton-tools update #1446
Merged
tekton-tools update #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![rh-tap-build-team[bot]](https://avatars.githubusercontent.com/u/89927105?s=60&v=4){kind=small}
rh-tap-build-team
bot
force-pushed
the
tekton-tools
branch
from
36f3446 to
ef11db2
Compare
avi-biton
approved these changes
Sep 19, 2024
mmorhun
reviewed
Sep 19, 2024
| @@ -5,19 +5,27 @@ metadata: | |||
| name: rpms-signature-scan | |||
| spec: | |||
| params: | |||
| - name: INPUT | |||
| - name: image-url | |||
There was a problem hiding this comment.
This is a breaking change. Do we need to create a new version of the task or all users of the task are aware of this?
There was a problem hiding this comment.
Its a new task that we just created few days ago, we are modifying everything before adding it to the template and before its been used by anyone.
mmorhun
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included PRs: