-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move ta-generator to task-generator directory #1439
Conversation
c2273f2
to
4a51da6
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
ce3bd99
to
1984417
Compare
- ta-generator and task-generator are currently on the same directory level - move ta-generator so it's a subdirectory of the task-generator leading to a better file organization in the repository - update .gitignore so it ignores vendor directories and diff files used in trusted-artifacts task generation testing
- reflect the move of the trusted-artifacts task generator to the task-generator directory in the README - add a README into every task-generator subdirectory
1984417
to
cf10465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optionally, we could make the task-generator directory a Go workspace to tie the two submodules together.
But TBH, I'm not entirely sure what problems Go workspaces solve, so we can leave it as is
Thank you for the review! I would like to avoid using Go workspace if possible. The Go Modules reference mentions |
ta-generator and task-generator are currently on the same directory level.
Move ta-generator so it's a subdirectory of the task-generator leading to a better file organization in the repository.
files used in trusted-artifacts task generation testing
task generator to the task-generator directory
in the README