Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ta-generator to task-generator directory #1439

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

tnevrlka
Copy link
Contributor

ta-generator and task-generator are currently on the same directory level.
Move ta-generator so it's a subdirectory of the task-generator leading to a better file organization in the repository.

  • update .gitignore so it ignores vendor directories and diff
    files used in trusted-artifacts task generation testing
  • reflect the move of the trusted-artifacts
    task generator to the task-generator directory
    in the README
  • add a README into every task-generator subdirectory

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@tnevrlka tnevrlka force-pushed the merge-generators branch 2 times, most recently from ce3bd99 to 1984417 Compare September 19, 2024 08:28
@tnevrlka tnevrlka marked this pull request as ready for review September 19, 2024 08:29
@openshift-ci openshift-ci bot requested review from chmeliik and rcerven September 19, 2024 08:29
- ta-generator and task-generator are currently
on the same directory level
- move ta-generator so it's a subdirectory of the task-generator
leading to a better file organization in the repository
- update .gitignore so it ignores vendor directories and diff
files used in trusted-artifacts task generation testing
- reflect the move of the trusted-artifacts
task generator to the task-generator directory
in the README
- add a README into every task-generator subdirectory
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally, we could make the task-generator directory a Go workspace to tie the two submodules together.

But TBH, I'm not entirely sure what problems Go workspaces solve, so we can leave it as is

@tnevrlka
Copy link
Contributor Author

Thank you for the review!

I would like to avoid using Go workspace if possible. The Go Modules reference mentions It is generally inadvisable to commit go.work files into version control systems and I'm not familiar with Go workspaces enough to understand if our use case warrants it.

@tnevrlka tnevrlka added this pull request to the merge queue Sep 20, 2024
Merged via the queue into konflux-ci:main with commit 6f92346 Sep 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants