Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RHTAPWATCH-1248): Provide admin user/pwd combo for ephemeral clusters #1403

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Kousalya1998
Copy link

  • Add admin username and password in the credentials volume
  • Add APIserverURL and ConsoleURL status field values from the CTI in the results

@openshift-ci openshift-ci bot requested review from chmeliik and tisutisu September 11, 2024 16:24
@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-1248 branch 2 times, most recently from 44ae673 to 56c614c Compare September 11, 2024 16:26
Copy link
Contributor

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this until @Kousalya1998 and I confirm it works properly.

@Kousalya1998 please move this to a draft state.

@Kousalya1998 Kousalya1998 marked this pull request as draft September 11, 2024 20:13
@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-1248 branch 2 times, most recently from fa4ac32 to 5d2d12e Compare September 12, 2024 18:23
@Kousalya1998 Kousalya1998 marked this pull request as ready for review September 12, 2024 18:24
@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-1248 branch 2 times, most recently from c7ae955 to 8ac8c00 Compare September 16, 2024 15:42
Copy link
Contributor

@amisstea amisstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although there are some yaml linting errors to sort out still.

@Kousalya1998
Copy link
Author

LGTM although there are some yaml linting errors to sort out still.

checking that..

@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-1248 branch 2 times, most recently from cbf320d to 126264a Compare September 16, 2024 20:59
@amisstea
Copy link
Contributor

@Kousalya1998 your commits could use some cleanup. There should be just one.

@Kousalya1998
Copy link
Author

squashed the commits

@amisstea
Copy link
Contributor

@chmeliik please review and merge if possible.

@chmeliik chmeliik enabled auto-merge September 17, 2024 14:16
@Kousalya1998
Copy link
Author

/retest

@chmeliik chmeliik added this pull request to the merge queue Sep 17, 2024
Merged via the queue into konflux-ci:main with commit ace36c6 Sep 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants