Removes unused workdir volume form oci-copy Task #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnevrlka
approved these changes
Sep 11, 2024
zregvart
force-pushed
the
pr/remove-duplicate-workdir-volume
branch
from
46e523f to
53fe55d
Compare
zregvart
force-pushed
the
pr/remove-duplicate-workdir-volume
branch
3 times, most recently
from
add5010 to
9ebbfee
Compare
There is no volumeMount for workdir in the oci-copy task, and it's presence in the volumes causes duplicate volumes in the oci-copy-oci-ta Task. This could also be resolved by making the generator aware of duplicate volumes and volumeMounts. Let's do that if it indeed does become an issue.
zregvart
force-pushed
the
pr/remove-duplicate-workdir-volume
branch
from
9ebbfee to
3f3d079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no volumeMount for workdir in the oci-copy task, and it's presence in the volumes causes duplicate volumes in the oci-copy-oci-ta Task.
This could also be resolved by making the generator aware of duplicate volumes and volumeMounts. Let's do that if it indeed does become an issue.