Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/operator-sdk-generate-bundle: --extra-service-accounts #1290

Merged
merged 1 commit into from
Aug 13, 2024
Merged

task/operator-sdk-generate-bundle: --extra-service-accounts #1290

merged 1 commit into from
Aug 13, 2024

Conversation

jbpratt
Copy link
Contributor

@jbpratt jbpratt commented Aug 13, 2024

allow for passing the --extra-service-accounts operator-sdk flag in to configure additional cluster permissions in the CSV

❯ operator-sdk generate bundle --overwrite \
        --version 4.16.265-f15333d --input-dir deploy \
        --package osd-example-operator --channels stable \
       --kustomize-dir config/manifests/ --extra-service-accounts osd-example-admin
❯ cat bundle/manifests/osd-example-operator.clusterserviceversion.yaml
apiVersion: operators.coreos.com/v1alpha1
kind: ClusterServiceVersion
metadata:
...
  name: osd-example-operator.v4.16.265-f15333d
  namespace: openshift-osd-example-operator
spec:
...
  install:
    spec:
      clusterPermissions:
      - rules:
        - apiGroups:
          - '*'
          resources:
          - '*'
          verbs:
          - '*'
        - nonResourceURLs:
          - '*'
          verbs:
          - '*'
        serviceAccountName: osd-example-admin
...

@jbpratt
Copy link
Contributor Author

jbpratt commented Aug 13, 2024

/cc @chmeliik

PTAL!! Thank you for your time!

@jbpratt jbpratt force-pushed the extra-service-accounts-flag branch from c36e60d to 23e82fa Compare August 13, 2024 14:21
gurnben
gurnben approved these changes Aug 13, 2024
View reviewed changes
Copy link

@gurnben gurnben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbpratt
task/operator-sdk-generate-bundle: --extra-service-accounts
4dc95db 
allow for passing the `--extra-service-accounts` operator-sdk flag in to
configure additional cluster permissions in the CSV

Signed-off-by: Brady Pratt <[email protected]>
@jbpratt jbpratt force-pushed the extra-service-accounts-flag branch from 23e82fa to 4dc95db Compare August 13, 2024 14:27
@chmeliik
Copy link
Contributor

/ok-to-test

@chmeliik chmeliik enabled auto-merge August 13, 2024 14:30
@chmeliik chmeliik added this pull request to the merge queue Aug 13, 2024
Merged via the queue into konflux-ci:main with commit 3984e5f Aug 13, 2024
9 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Aug 13, 2024
Closed
@jbpratt jbpratt deleted the extra-service-accounts-flag branch August 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmeliik chmeliik chmeliik approved these changes

@gurnben gurnben gurnben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbpratt @chmeliik @gurnben