Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/operator-sdk-generate-bundle: kustomize-dir param #1276

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jbpratt
Copy link
Contributor

@jbpratt jbpratt commented Aug 9, 2024

allow setting --kustomize-dir flag when generating the bundle. This works for generating using a base CSV. If the string is empty (default), it will build without an existing base and generate the default CSV.

Copy link

@gurnben gurnben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, param description optional

allow setting `--kustomize-dir` flag when generating the bundle. This
works for generating using a base CSV. If the string is empty (default),
it will build without an existing base and generate the default CSV.

Signed-off-by: Brady Pratt <[email protected]>
@jbpratt jbpratt force-pushed the kustomize-dir-param branch from dcd9ac4 to cc1c479 Compare August 12, 2024 12:25
@chmeliik
Copy link
Contributor

/ok-to-test

@chmeliik chmeliik enabled auto-merge August 12, 2024 15:11
@chmeliik chmeliik added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@jbpratt
Copy link
Contributor Author

jbpratt commented Aug 13, 2024

@chmeliik this one got removed from the merge queue 😿

@chmeliik chmeliik added this pull request to the merge queue Aug 13, 2024
Merged via the queue into konflux-ci:main with commit 6766ab1 Aug 13, 2024
9 checks passed
@jbpratt jbpratt deleted the kustomize-dir-param branch August 13, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants