Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tekton-tools update #1081

Merged
merged 5 commits into from
Jul 22, 2024
Merged

tekton-tools update #1081

merged 5 commits into from
Jul 22, 2024

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Jun 20, 2024 •
edited
Loading

Included PRs:

chmeliik
chmeliik reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be downgrading the version of the konflux-test image. @yftacherzog could you take a look if this is intentional?

@yftacherzog
Copy link
Member

This seems to be downgrading the version of the konflux-test image. @yftacherzog could you take a look if this is intentional?

@Omeramsc @avi-biton, can check this?

@Omeramsc
Copy link

Weird that we are seeing it only now, on an unrelated change, but maybe it is related to https://github.com/redhat-appstudio/tekton-tools/pull/112/files ?
Seems like one prevention of a revert may cause a different revert

@rh-tap-build-team rh-tap-build-team bot force-pushed the tekton-tools branch 3 times, most recently from 4d0f544 to 8501077 Compare July 2, 2024 10:03
@yftacherzog
Copy link
Member

This seems to be downgrading the version of the konflux-test image. @yftacherzog could you take a look if this is intentional?

@chmeliik My guess would be that the reference to this image is not being updated automatically in tekton-tools repo. What sort of automation should be in place for it to be updated?

@chmeliik
Copy link
Contributor

This seems to be downgrading the version of the konflux-test image. @yftacherzog could you take a look if this is intentional?

@chmeliik My guess would be that the reference to this image is not being updated automatically in tekton-tools repo. What sort of automation should be in place for it to be updated?

In this repo it's done by Renovate #1120

@rh-tap-build-team rh-tap-build-team bot force-pushed the tekton-tools branch 4 times, most recently from a6cb6c9 to d31f90a Compare July 10, 2024 09:55
@yftacherzog
Copy link
Member

This seems to be downgrading the version of the konflux-test image. @yftacherzog could you take a look if this is intentional?

@chmeliik My guess would be that the reference to this image is not being updated automatically in tekton-tools repo. What sort of automation should be in place for it to be updated?

In this repo it's done by Renovate #1120

@chmeliik We updated that image in tekton-tools. It now has the same version as the one on that other PR you referred to.

@yftacherzog
Copy link
Member

/retest

1 similar comment
@yftacherzog
Copy link
Member

/retest

@yftacherzog
Copy link
Member

@chmeliik do you think we can have this one merged?

@chmeliik chmeliik enabled auto-merge July 22, 2024 13:17
@chmeliik chmeliik added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 3e0517a Jul 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmeliik chmeliik chmeliik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yftacherzog @Omeramsc @chmeliik @openshift-merge-robot