-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task to build RHEL AI #1059
Conversation
fe35af3
to
cd2c66b
Compare
/retest |
cd2c66b
to
53706c9
Compare
So we can see more of what's happening.
…info so we can look into disabling fsync to improve performance.
/retest |
cd4837c
to
2bcb29d
Compare
927c5ff
to
2b2fd7e
Compare
…t-entitlment usage
To make it clear what arguments are passed
/retest |
Looks like this is failing |
type: string | ||
- name: OUTPUT_IMAGE | ||
type: string | ||
description: The output manifest list that points to the OCI artifact of the zipped ZM image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's ZM
? Is it a typo? If not, could you expand it in the description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ralphbean@71b679b.
echo "declare SOURCE_IMAGE=${SOURCE_IMAGE}" >> /var/workdir/vars | ||
|
||
# here we should validate that both keys exist and are valid pullspecs. | ||
# todo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 2903e81.
- name: etc-pki-entitlement | ||
secret: | ||
optional: true | ||
secretName: $(params.ENTITLEMENT_SECRET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ralphbean@a6a4a63.
Closing this in favor of #1133. |
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.