-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure for hugo #183
Restructure for hugo #183
Conversation
I'm seeing really weird failures here with hugo that I don't understand. The Then, run Notice that these urls work:
But this url does not work:
That last one should be an index of the design documents... but, it is empty. I can make it render with a list of design docs if I remove what seems to be an arbitrary number of the ADRs in the |
Do we need the the |
|
||
# Style options: default (light-blue), blue, green, marsala, pink, red, turquoise, violet | ||
style = "default" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try adding this line under [params] to be able to open
http://localhost:1313/architecture/
and http://localhost:1313/decisions
mainSections = ["architecture", "decisions"]
According to https://gohugo.io/methods/site/mainsections/
if mainSections
is not specified, it will only display the section with most pages.
If params.mainSections is not defined in the site configuration, this method returns a slice with one element—the top level section with the most pages.
Also have a look at #184 |
|
Now that the architecture repo is building successfully at https://konflux-ci.dev/architecture/ with jekyll, I'm not sure I have the motivation to finish this PR - there's still a good bit more cleanup to do to get the style to match https://konflux-ci.dev/ Do either of you want to pick up the remaining work in this PR? If so, feel free to, otherwise I think I'll drop it. |
Beside my bias towards Hugo, I'm not sure much is gained by transition from Jekyll to Hugo. Is there something we wish to gain with this? |
@zregvart I think the only thing at this point is alignment of the style between https://konflux-ci.dev/ and https://konflux-ci.dev/architecture/ |
In konflux-ci/konflux-ci.github.io#39 the custom CSS and images are pulled in to a theme that can be addressable via Hugo modules, i.e. changing the diff --git a/hugo.toml b/hugo.toml
index b950f08..8172d71 100644
--- a/hugo.toml
+++ b/hugo.toml
@@ -1,7 +1,7 @@
baseURL = 'http://localhost:1313/'
languageCode = 'en-us'
title = 'Standalone Konflux Architecture Docs'
-theme = 'github.com/devcows/hugo-universal-theme'
+theme = ['github.com/konflux-ci/konflux-ci.github.io/website/themes/konflux', 'github.com/devcows/hugo-universal-theme']
# Site language. Available translations in the theme's `/i18n` directory.
defaultContentLanguage = "en"
Would bring in the styling of konflux-ci.dev |
With #188 the overall styling of konflux-ci.dev website can be inherited here as well. |
In #189 I've restructured the ADR decisions to add front matter and added a custom list layout for decisions, it renders a bit nicer now. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
1 similar comment
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Adds custom "list" layout and modifies the markdown files to add front matter.
This adds the theme from konflux-ci.dev as a Hugo module. Any styling changes there are applied to this website as well. The version is pinned, so updates to konflux-ci.dev will not be applied without running `hugo mod get -u`.
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
@zregvart 00d755c had a side effect that I don't understand. Before it, urls like http://localhost:1313/architecture/release-service/ would render correctly, but after it they do not. |
@ralphbean pushed |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
@ralphbean in #190 I've used |
This was helpful to generate the API docs locally so I can preview and run the link checker to check for broken links. Adds the `tools/go.mod` so the version of `crd-ref-docs` can be pinned, and the tool can be run using `go run`. In essence one can do `make api-docs` to generate the Markdown files in `content/ref`. There is a small issue with the `service-provider-integration-operator`, it needs an additional `go mod tidy` if golang version is newer than 1.20. To fix that run `make api-docs` once to clone the repository, then `cd crd-temp/service-provider && go mod tidy` and rerun `make api-docs`.
#191 was useful for previewing locally |
Generate API reference using Make
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
No description provided.