Attempt to improve the module #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK! Thanks for your contribution! I will review your changes, let me few days! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I updated the package,json to use the latest versions of things.
I wanted functionality that puts the cursor at the end of the number because the focusing is all weird. I also attempted to put the images you use into your module so that there is no need to go across the internet to get these 2 little images, but I ran into a snag. I was having a tough time testing your code for some reason. I made the changes that I thought should make it work, but was unable to test it fully so I STRONGLY recommend you test this first before merging it.
Please let me know if you are able to merge this or let me know how I can better test it in your demo environment. Thanks!