Update to ZXing 3.3.0 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naei
commented
Feb 21, 2017
| @@ -13,7 +13,11 @@ module.exports = function (options) { | |||
| } | |||
|
|
|||
| if(defaults.ZXingVersion == null) { | |||
| defaults.ZXingVersion = "-3.1.0" | |||
| defaults.ZXingVersion = "3.3.0" | |||
There was a problem hiding this comment.
I moved the "-" separator outside the variable, however I wonder now if it was voluntarily put here for some reason in the first place. Do not hesitate to rollback on this if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update jars to core-3.3.0 and javase-3.3.0 ; add ZXing dependency jcommander-1.60.jar ; update README