-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with selectedText solved #302
base: master
Are you sure you want to change the base?
Conversation
…ers au service a été déplacée dans le module plutôt que dans les 2 composants
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 19.45% 19.42% -0.03%
==========================================
Files 7 7
Lines 478 489 +11
Branches 104 105 +1
==========================================
+ Hits 93 95 +2
- Misses 372 381 +9
Partials 13 13
Continue to review full report at Codecov.
|
Hi! Check your PR please. |
Hi Andrey, what do you means by this ? Charles |
I think you pulled wrong branch... |
I had a problem with the selection of text and the possibility to create a link.
The problem was that the service was not shared between the toolbar and the editor itself.
I removed the providers references from the two components to the module.
(Also upgraded the project to Angular 10)