More tests #9
Merged
More tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/tests
branch
8 times, most recently
from
3fd3bd6 to
228736d
Compare
RebeccaMahany
force-pushed
the
becca/tests
branch
16 times, most recently
from
94b40e1 to
aadd493
Compare
RebeccaMahany
force-pushed
the
becca/tests
branch
from
aadd493 to
73ca78f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current CI validates the flake but doesn't really validate the module. This PR adds a check that exercises the module as well, ensuring that it's well-formed and installable. It also lays the groundwork for some cool screenshots in the future. (It uses Mate because I was mostly unsuccessful with Gnome, Cinnamon, and Xfce, though I think that will be easy to fix in the future.)
See test documentation here: https://nixos.org/manual/nixos/stable/index.html#sec-nixos-tests
See example screenshot from test artifact here
Artifact from here: https://github.com/kolide/nix-agent/actions/runs/7453070686
In the future, after kolide/launcher#1473 is complete, we'd look for the Kolide icon to see desktop is running.