New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include windows for cleanup retries in runtime tests #2042

Merged

zackattack01 merged 1 commit into main from zack/test_improvements

Jan 10, 2025

Contributor

zackattack01 commented Jan 10, 2025

this should seem like redundant cleanup but I think the retries were mostly intended for windows here, some notes:

t.TempDir() also uses t.Cleanup() under the hood
- that cleanup also has retries (only for 2 seconds) but obviously fails from time to time
this cleanup will schedule our cleanup attempt first, giving us some additional time for things to clear up


          include windows for cleanup retries in runtime tests

cbf1cb1

RebeccaMahany approved these changes

View reviewed changes

James-Pickett approved these changes

View reviewed changes

zackattack01 added this pull request to the merge queue

Merged via the queue into main with commit 92c6d65

33 checks passed

zackattack01 deleted the zack/test_improvements branch

January 10, 2025 16:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet