runtime and agent test improvements #2014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime
testOsqueryBinaryDirectory
totestOsqueryBinary
for clarity. this was being used as a full path, and our download helpers alter this path to add.exe
but our global variable was not getting the same update, causing some confusing error messages. e.g.no binary at C:\Users\zack-\AppData\Local\Temp\3167415370\osqueryd
when one does exist atC:\Users\zack-\AppData\Local\Temp\3167415370\osqueryd.exe
.exe
extension to the variable for windows so those error messages stopdefer
beforeos.Exit
. this updates to use explicit removal calls for all error cases and before exitingexe
when required). hope is that these will be less confusing to debug and will stop leaking old test artifactsagent
osquery-runsimple
directories left behind- looking at the agentreset_test.go
we have the same defer vs os.Exit problem. this one does seem to add the.exe
correctly so nothing needed there